[1.3.0] use open file list browser to crash 1.3.0

[maxxarn 0]

I'm not allowed to start a new topic in the 1.3.x section so here it is. Move it if you want.

I can replicate this crash, but I haven't tried reboot and replicate it.

Why? Because It's past bedtime

Short version:

-Open the dialog for open file list

-Use it to browse somewhere else and right click on a directory = crash

-Use it to browse somewhere and left single click a directory and press Delete on board = crash

Info:

-I run WinXP Home fully updated, but every single unneccesary service disabled. (yeah, old slow pc...)

-I'm logged in as a user but ApexDC crash both when running with normal user rights as well as running with elevated rights via the "Run As" option.

The crash background:

ApexDC++ (all previous and also 1.3.0) locks any downloaded folder and won't let the user delete or move that folder as long as the ApexDC++ process is running if said folder is created via "download to" (or whatever it's called in english, I use Swedish translation) in search results. This lock up is also occurs under some other cases like add source to file when finding additional sources for a file alredey in DL-queue.

So I found the crash when I thought I'd try to delete the folder from within the process that's locking up the folder. So I loaded up the open file list dialog and used it to browse to said folder. Rest is history...

Peace!

Code: c0000005 (Access violation)

Version: 1.3.0 (Feb 24 2010)

Major: 5

Minor: 1

Build: 2600

SP: 3

Type: 1

Time: 2010-03-02 00:56:55

TTH: Q5QXAFJ2LR6ECJK66RWRL2SWKQ2PJPD7TNFIYFQ

kernel32!0x7C80D00D: LCMapStringW

kernel32!0x7C80D1A9: CompareStringA

kernel32!0x7C830DA1: lstrcmpA

BfsExt!0x08761811: ?

SHELL32!0x7CA177A9: PathProcessCommand

SHELL32!0x7CA18006: PathProcessCommand

SHELL32!0x7CAA6886: Ordinal712

SHELL32!0x7CAA9CFD: Ordinal712

SHELL32!0x7CAAC3F9: Ordinal712

SHELL32!0x7CA020AD: SHCreateShellFolderView

SHELL32!0x7C9F2F88: Ordinal128

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E378EA0: DefWindowProcW

USER32!0x7E378EEC: DefWindowProcW

ntdll!0x7C90E473: KiUserCallbackDispatcher

SHELL32!0x7CAA9EF9: Ordinal712

comdlg32!0x7639A0FD: GetOpenFileNameA

USER32!0x7E37B372: MoveWindow

USER32!0x7E37B317: MoveWindow

USER32!0x7E3778D0: GetWindowTextLengthW

ntdll!0x7C90E473: KiUserCallbackDispatcher

USER32!0x7E37747E: IsDialogMessageW

USER32!0x7E37763C: CallMsgFilterW

USER32!0x7E3749C4: GetCursorFrameInfo

USER32!0x7E374A06: DialogBoxIndirectParamAorW

USER32!0x7E38208D: DialogBoxIndirectParamW

comdlg32!0x7639355F: GetOpenFileNameA

comdlg32!0x76393366: GetOpenFileNameA

comdlg32!0x7639333D: GetOpenFileNameA

comdlg32!0x763A7BFF: GetOpenFileNameW

d:\development\dcdev\apexdc\1.3.0\windows\winutil.cpp(739): WinUtil::browseFile

d:\development\dcdev\apexdc\1.3.0\windows\mainfrm.cpp(1540): MainFrame::onOpenFileList

d:\development\dcdev\apexdc\1.3.0\windows\mainfrm.h(166): MainFrame::ProcessWindowMessage

d:\development\includes\wtl\atlframe.h(1506): WTL::CMDIFrameWindowImpl<MainFrame=0x00000000,WTL::CMDIWindow=0x00000111,ATL::CWinTraits<114229248=0x00000435,262400> >::MDIFrameWindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37A013: IsWindowUnicode

USER32!0x7E37A039: CallWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3981): ATL::CContainedWindowT<ATL::CWindow=0x0006F28C,ATL::CWinTraits<1442840576=0x00000111,0> >::WindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37927B: GetParent

USER32!0x7E3792E3: SendMessageW

COMCTL32!0x77436313: CreateToolbar

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37A013: IsWindowUnicode

USER32!0x7E37A039: CallWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3034): ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase=0x00000111,ATL::CWinTraits<1442840576=0x00000435,0> >::DefWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3089): ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase=0x0006F230,ATL::CWinTraits<1442840576=0x00000000,0> >::WindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E3689CD: GetWindowLongW

USER32!0x7E368A10: DispatchMessageW

d:\development\includes\wtl\atlapp.h(1058): WTL::CMessageLoop::Run

d:\development\dcdev\apexdc\1.3.0\windows\main.cpp(445): Run

ApexDC!0x007701D4: ?

ApexDC!0x00452B60: MainFrame::FileListQueue::`scalar deleting destructor'

ApexDC!0x0046FBA3: [thunk]:MainFrame::`vector deleting destructor'

0x8351F8E4: ?

[maxxarn 0]

Rebooted and can replicate the crash logged in with only user rights.

(Edit. Logged in as admin as well and still can replicate the crash)

Code: c0000005 (Access violation)

Version: 1.3.0 (Feb 24 2010)

Major: 5

Minor: 1

Build: 2600

SP: 3

Type: 1

Time: 2010-03-02 02:06:42

TTH: Q5QXAFJ2LR6ECJK66RWRL2SWKQ2PJPD7TNFIYFQ

kernel32!0x7C80D00D: LCMapStringW

kernel32!0x7C80D1A9: CompareStringA

kernel32!0x7C830DA1: lstrcmpA

BfsExt!0x03271811: ?

SHELL32!0x7CA177A9: PathProcessCommand

SHELL32!0x7CA18006: PathProcessCommand

SHELL32!0x7CAA8C2E: Ordinal712

SHELL32!0x7CAABCE6: Ordinal712

SHELL32!0x7CA0211E: SHCreateShellFolderView

SHELL32!0x7C9F2F88: Ordinal128

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E378EA0: DefWindowProcW

USER32!0x7E378EEC: DefWindowProcW

ntdll!0x7C90E473: KiUserCallbackDispatcher

USER32!0x7E378DD9: DefWindowProcW

uxtheme!0x5B271AF6: ?

uxtheme!0x5B271B3D: ?

USER32!0x7E3794ED: GetPropW

COMCTL32!0x77410D82: Ordinal384

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37927B: GetParent

USER32!0x7E3792E3: SendMessageW

COMCTL32!0x77410A7E: Ordinal384

COMCTL32!0x77410AB6: Ordinal384

COMCTL32!0x774114E9: Ordinal384

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E3689CD: GetWindowLongW

USER32!0x7E368A10: DispatchMessageW

USER32!0x7E3774FF: IsDialogMessageW

USER32!0x7E37763C: CallMsgFilterW

USER32!0x7E3749C4: GetCursorFrameInfo

USER32!0x7E374A06: DialogBoxIndirectParamAorW

USER32!0x7E38208D: DialogBoxIndirectParamW

comdlg32!0x7639355F: GetOpenFileNameA

comdlg32!0x76393366: GetOpenFileNameA

comdlg32!0x7639333D: GetOpenFileNameA

comdlg32!0x763A7BFF: GetOpenFileNameW

d:\development\dcdev\apexdc\1.3.0\windows\winutil.cpp(739): WinUtil::browseFile

d:\development\dcdev\apexdc\1.3.0\windows\mainfrm.cpp(1540): MainFrame::onOpenFileList

d:\development\dcdev\apexdc\1.3.0\windows\mainfrm.h(166): MainFrame::ProcessWindowMessage

d:\development\includes\wtl\atlframe.h(1506): WTL::CMDIFrameWindowImpl<MainFrame=0x00000000,WTL::CMDIWindow=0x00000111,ATL::CWinTraits<114229248=0x00000435,262400> >::MDIFrameWindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37A013: IsWindowUnicode

USER32!0x7E37A039: CallWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3981): ATL::CContainedWindowT<ATL::CWindow=0x0006F28C,ATL::CWinTraits<1442840576=0x00000111,0> >::WindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37927B: GetParent

USER32!0x7E3792E3: SendMessageW

COMCTL32!0x77436313: CreateToolbar

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E37A013: IsWindowUnicode

USER32!0x7E37A039: CallWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3034): ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase=0x00000111,ATL::CWinTraits<1442840576=0x00000435,0> >::DefWindowProcW

c:\program files\microsoft visual studio 9.0\vc\atlmfc\include\atlwin.h(3089): ATL::CWindowImplBaseT<WTL::CCommandBarCtrlBase=0x0006F230,ATL::CWinTraits<1442840576=0x00000000,0> >::WindowProc

USER32!0x7E368734: GetDC

USER32!0x7E368816: GetDC

USER32!0x7E3689CD: GetWindowLongW

USER32!0x7E368A10: DispatchMessageW

d:\development\includes\wtl\atlapp.h(1058): WTL::CMessageLoop::Run

d:\development\dcdev\apexdc\1.3.0\windows\main.cpp(445): Run

0x00050262: ?

ApexDC!0x00452B60: MainFrame::FileListQueue::`scalar deleting destructor'

ApexDC!0x0046FBA3: [thunk]:MainFrame::`vector deleting destructor'

0x8351F8E4: ?

[air 0]

Both confirmed. And no exceptioninfo.txt generated in my case.

This is the old one crash i've noticed in 1.2.0, alas it seems to be still not fixed.

Rightclick version happens with any folder my cursor comes in touch with.

[Crise 26]

I can't replicate this issue with windows 7, will check under XP later but it looks as if this could be windows issue, however, I'll still look at the documentation for those two dialogs (since they come straight from windows).

[Big Muscle 1]

As visible in the callstack, the library BfsExt.dll is responsible for the crash. Uninstall program which uses it and everything will be fine.

[air 0]

Since I've moved to win7, how can I possibly detect or guess the matter of similar library conflict when suddenly the same situation occurs and no exceptioninfo is generated? I'm from Russia, but I still don't like the idea of uninstalling half of my system in russian roulette style to guess which program causes apex to shut down in such a speechless manner.

[Crise 26]

Since I've moved to win7, how can I possibly detect or guess the matter of similar library conflict when suddenly the same situation occurs and no exceptioninfo is generated? I'm from Russia, but I still don't like the idea of uninstalling half of my system in russian roulette style to guess which program causes apex to shut down in such a speechless manner.

I have yet to figure out how to "fix" the exception infos on post XP systems for end users (since even though they get generated they are lot less informative than those coming from XP based systems) despite looking into it several times. (it could be that I am missing something really obvious though).