random crashes

[SMT 0]

apex crushed when trying to display user, that leaving hub in this moment. this bug was confirmed by 3 users. here is report

Code: c0000005 (Access violation)

Version: s10.1 (2007-01-04)

Major: 5

Minor: 1

Build: 2600

SP: 2

Type: 1

Time: 2007-01-05 01:47:03


exception code C0000005 at eip=0042CA9A, nested: 00000000

eax=00D97260 ebx=00000000 ecx=00000000 edx=00000000

esi=00000000 edi=0012C5A4 ebp=0012C578 esp=0012C568

ApexDC-s10_1!0x0042CA9A: ?

ApexDC-s10_1!0x004A9967: ?

ApexDC-s10_1!0x004A84A3: ?

ApexDC-s10_1!0x0044E7C7: ?

ApexDC-s10_1!0x0041D55D: ?

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3B368: DefWindowProcW

USER32!0x77D3B3B4: DefWindowProcW

ntdll!0x7C90EAE3: KiUserCallbackDispatcher

USER32!0x77D3B7AB: SendMessageW

COMCTL32!0x773DAF7B: Ordinal414

COMCTL32!0x773DB009: Ordinal341

COMCTL32!0x7742C307: FlatSB_SetScrollProp

COMCTL32!0x77407720: FlatSB_SetScrollProp

COMCTL32!0x7740D520: FlatSB_SetScrollProp

COMCTL32!0x7740E4C6: FlatSB_SetScrollProp

COMCTL32!0x77410DDA: FlatSB_SetScrollProp

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3C00E: DestroyCaret

USER32!0x77D3C034: CallWindowProcW

ApexDC-s10_1!0x0047C5E3: ?

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3B368: DefWindowProcW

USER32!0x77D3B3B4: DefWindowProcW

ntdll!0x7C90EAE3: KiUserCallbackDispatcher

COMCTL32!0x7740B75E: FlatSB_SetScrollProp

COMCTL32!0x7740B7C0: FlatSB_SetScrollProp

COMCTL32!0x774106D7: FlatSB_SetScrollProp

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3C00E: DestroyCaret

USER32!0x77D3C034: CallWindowProcW

ApexDC-s10_1!0x0047C5E3: ?

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3B368: DefWindowProcW

USER32!0x77D3B3B4: DefWindowProcW

ntdll!0x7C90EAE3: KiUserCallbackDispatcher

COMCTL32!0x7740DB4F: FlatSB_SetScrollProp

COMCTL32!0x77410951: FlatSB_SetScrollProp

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3C00E: DestroyCaret

USER32!0x77D3C034: CallWindowProcW

ApexDC-s10_1!0x0047C5E3: ?

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D3B368: DefWindowProcW

USER32!0x77D3B3B4: DefWindowProcW

ntdll!0x7C90EAE3: KiUserCallbackDispatcher

USER32!0x77D3B7AB: SendMessageW

COMCTL32!0x773DAF7B: Ordinal414

COMCTL32!0x773FF71C: Ordinal384

COMCTL32!0x77401E79: Ordinal384

COMCTL32!0x77403053: Ordinal384

USER32!0x77D38709: GetDC

USER32!0x77D387EB: GetDC

USER32!0x77D389A5: GetWindowLongW

USER32!0x77D389E8: DispatchMessageW

the error is in the following code, bolded is dereferenced null-object:

LRESULT HubFrame::onCustomDraw(int /*idCtrl*/, LPNMHDR pnmh, BOOL& /*bHandled*/) {

LPNMLVCUSTOMDRAW cd = (LPNMLVCUSTOMDRAW)pnmh;

switch(cd->nmcd.dwDrawStage) {

case CDDS_PREPAINT:

return CDRF_NOTIFYITEMDRAW;

case CDDS_ITEMPREPAINT: {

UserInfo* ui = (UserInfo*)cd->nmcd.lItemlParam;

if (FavoriteManager::getInstance()->isFavoriteUser(ui->getUser())) {

cd->clrText = SETTING(FAVORITE_COLOR);

} else if (UploadManager::getInstance()->hasReservedSlot(ui->getUser())) {

cd->clrText = SETTING(RESERVED_SLOT_COLOR);

} else if (ignoreList.find(ui->getUser()) != ignoreList.end()) {

cd->clrText = SETTING(IGNORED_COLOR);

} else if(ui->getUser()->isSet(User::FIREBALL)) {

cd->clrText = SETTING(FIREBALL_COLOR);

} else if(ui->getUser()->isSet(User::SERVER)) {

cd->clrText = SETTING(SERVER_COLOR);

} else if(ui->getIdentity().isOp()) {

cd->clrText = SETTING(OP_COLOR);

} else if(!ui->getIdentity().isTcpActive()) {

cd->clrText = SETTING(PASIVE_COLOR);

} else {

cd->clrText = SETTING(NORMAL_COLOUR);

}

[...]

[deity 0]

I think Lee read you topic and as always wrote like that....Very interesting but ...then just PM Crise or me....

and after

TOPIC CLOSED

P.S>

I just try to read you posts on this forum and in end of many developers KILLED discussion...

Dot know why...

[Crise 26]

I think Lee read you topic and as always wrote like that....Very interesting but ...then just PM Crise or me....

and after

TOPIC CLOSED

P.S>

I just try to read you posts on this forum and in end of many developers KILLED discussion...

Dot know why...

Not true, in regards to posts such as these, discussion can go on normally (besides only 2 topics from SMT have been locked)

[SMT 0]

really there is no to discuss. the only purpose of this topic is to warn DC++ client developers (that, of course, visits this site but don't watch out for changelogs of all unofficial mods) to update code. PM-ing will delay updates until new official Apex version, that it's not preferrable

[Crise 26]

really there is no to discuss. the only purpose of this topic is to warn DC++ client developers (that, of course, visits this site but don't watch out for changelogs of all unofficial mods) to update code. PM-ing will delay updates until new official Apex version, that it's not preferrable

I do check out the changelogs for unofficial mods... but as for currently the source your mod is based on is very different from the source i am working on atm. because of some measures i had to do in the near past :crying: